patches/react-native-navigation+7.45.0.patch (2)

263-273: ⚠️ Potential issue | 🟠 Major

Potential ClassCastException in invalidate() method

The activity() method now returns Activity instead of NavigationActivity, but invalidate() performs a direct cast without a guard. If the current activity is not a NavigationActivity, this will throw a ClassCastException. This is inconsistent with the defensive Optional pattern applied elsewhere in this file.

🐛 Proposed fix to add instanceof check

 `@Override`
 public void invalidate() {
-    final NavigationActivity navigationActivity = (NavigationActivity)activity();
-    if (navigationActivity != null) {
+    final Activity current = activity();
+    if (current instanceof NavigationActivity) {
+        final NavigationActivity navigationActivity = (NavigationActivity) current;
         navigationActivity.onCatalystInstanceDestroy();
     }
     super.invalidate();
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@patches/react-native-navigation`+7.45.0.patch around lines 263 - 273,
invalidate() currently casts activity() to NavigationActivity directly which can
throw ClassCastException; change the method to retrieve the Activity (via
activity()), check "instanceof NavigationActivity" before casting, and only call
navigationActivity.onCatalystInstanceDestroy() if the check passes; keep the
call to super.invalidate() unmodified. Reference symbols: invalidate(),
activity(), NavigationActivity, onCatalystInstanceDestroy(), super.invalidate().

---

353-372: ⚠️ Potential issue | 🟡 Minor

Inconsistent null-safety: !! assertion on nullable getEventDispatcher()

The getEventDispatcher() return type was changed to EventDispatcher? (nullable), but lines 357, 364, and 371 use !! (non-null assertion). If getEventDispatcher() returns null, this will throw a NullPointerException, negating the null-safety improvements.

🛡️ Proposed fix to handle nullable dispatcher consistently

     override fun onChildStartedNativeGesture(child: View, androidEvent: MotionEvent?) {
-        androidEvent?.let {
-            mJSTouchDispatcher.onChildStartedNativeGesture(it, this.getEventDispatcher()!!)
+        val dispatcher = getEventDispatcher() ?: return
+        androidEvent?.let {
+            mJSTouchDispatcher.onChildStartedNativeGesture(it, dispatcher)
         }
     }
     override fun onChildStartedNativeGesture(androidEvent: MotionEvent?) {
-        androidEvent?.let {
-            mJSTouchDispatcher.onChildStartedNativeGesture(it, this.getEventDispatcher()!!)
+        val dispatcher = getEventDispatcher() ?: return
+        androidEvent?.let {
+            mJSTouchDispatcher.onChildStartedNativeGesture(it, dispatcher)
         }
     }
     override fun onChildEndedNativeGesture(child: View, androidEvent: MotionEvent?) {
-        androidEvent?.let {
-            mJSTouchDispatcher.onChildEndedNativeGesture(it, this.getEventDispatcher()!!)
+        val dispatcher = getEventDispatcher() ?: return
+        androidEvent?.let {
+            mJSTouchDispatcher.onChildEndedNativeGesture(it, dispatcher)
         }
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@patches/react-native-navigation`+7.45.0.patch around lines 353 - 372, The
code uses non-null assertions on a now-nullable getEventDispatcher() inside
onChildStartedNativeGesture and onChildEndedNativeGesture; instead of using !!,
check the dispatcher for null and bail out or safely call it (e.g., val
dispatcher = getEventDispatcher() ?: return or getEventDispatcher()?.let { ...
}) before calling mJSTouchDispatcher.onChildStartedNativeGesture /
onChildEndedNativeGesture so you never force-unwrap a nullable EventDispatcher;
update both overloads of onChildStartedNativeGesture and
onChildEndedNativeGesture to use a safe-check on getEventDispatcher().